Duplicate call in object completion

Post Reply
alfa24
Senior Boarder
Posts: 1237
Joined: Fri Nov 24, 2017 8:45 am
Version: forma.lms 1.4.2

Duplicate call in object completion

Post by alfa24 »

Hi all, this is for developers (a place where discussing technical topics, a git public repo where pull-request/commit proposals would be much appreciated).
I found that the completion of the course when a learning object is set as Terminator, is called twice:

1) in Track_Object::_setCourseCompleted (where it should be)
2) in organization_itemdone function (module organization, /appLms/modules/organization/organization.php)

The second can be safely removed. What do you think?
I'm Jasmines, the One. If you need, you can contact me.

Post Reply